Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inputComponents now get stable callbacks #819

Merged
merged 2 commits into from
May 13, 2024

Conversation

porcellus
Copy link
Collaborator

Summary of change

inputComponents now get stable callbacks, as it was intended originally.

Related issues

Test Plan

Modified the test app, so existing tests also check this.

Documentation changes

N/A

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs
  • If I added a new login method, I modified the list in lib/ts/types.ts
  • If I added a factor id, I modified the list in lib/ts/recipe/multifactorauth/types.ts

Copy link

github-actions bot commented Apr 30, 2024

size-limit report 📦

Path Size
lib/build/index.js 17.67 KB (0%)
recipe/session/index.js 18.69 KB (0%)
recipe/session/prebuiltui.js 21.5 KB (0%)
recipe/thirdpartyemailpassword/index.js 31.11 KB (0%)
recipe/thirdparty/index.js 27.5 KB (0%)
recipe/emailpassword/index.js 10.89 KB (0%)
recipe/emailverification/index.js 7.71 KB (0%)
recipe/passwordless/index.js 69.08 KB (0%)
recipe/thirdpartypasswordless/index.js 89.99 KB (0%)
recipe/emailverification/prebuiltui.js 27.43 KB (0%)
recipe/thirdpartyemailpassword/prebuiltui.js 62.56 KB (0%)
recipe/thirdparty/prebuiltui.js 44.02 KB (0%)
recipe/emailpassword/prebuiltui.js 33.33 KB (+0.01% 🔺)
recipe/passwordless/prebuiltui.js 116.74 KB (+0.01% 🔺)
recipe/thirdpartypasswordless/prebuiltui.js 146.95 KB (+0.01% 🔺)
recipe/multitenancy/index.js 6.54 KB (0%)
recipe/multifactorauth/index.js 10.63 KB (0%)
recipe/multifactorauth/prebuiltui.js 26.84 KB (0%)

@porcellus porcellus changed the base branch from 0.40 to 0.41 May 13, 2024 13:28
@porcellus porcellus merged commit 8b0919c into 0.41 May 13, 2024
26 of 30 checks passed
@porcellus porcellus deleted the fix/stable_inputComponent_callbacks branch May 13, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant