chore: Modify header based auth logic based on reviews #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
rishabhpoddar
approved these changes
Jan 9, 2023
rishabhpoddar
pushed a commit
that referenced
this pull request
Feb 1, 2023
* feat: Add logic to allow using headers instead of cookies (#74) * Make changes for fetch * Make changes for axios * Changes to test * Changes to test * Changes to test * Fix config tests * Fix config tests * Refactor * Fix fetch tests * Fix general error tests * Update axios tests * Update axios tests * Fic for axios * Fic for axios * Fixes * Fix header logic * Add axios 2 header tests * Fix issue with axios * Fix issue with axios * Fix issue with axios * Fix issue with axios * Add header tests for fetch * Add header checks for config tests * Make header the default mechanism * Update tests * Update based on PR review * Update tests * Add function to get access token * Add tests to make sure older sessions still work * Refactor * Refactor * Refactor * Refactor * Add axios tests * chore: Modify header based auth logic based on reviews (#79) * Add function to get access token * Add tests to make sure older sessions still work * Refactor * Refactor * Refactor * Refactor * Add axios tests * Add additional tests for fetch * Add additional tests for axios * Add tests * Export getAccessToken as a default export * Handle cookie strings for legacy sessions when reading tokens from storage * Add test for moving from old cookies to header * Update FDI, CHANGELOG and package versio * Refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
getAccessTokenfunctionRelated issues
Test Plan
All tests pass, added additional tests
Documentation changes
Checklist for important updates
frontendDriverInterfaceSupported.jsonfile has been updated (if needed)lib/ts/version.tspackage.jsonpackage-lock.jsonlib/ts/version.tsnpm run build-prettygit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.Remaining TODOs for this PR