Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Implement AMD FSR for upscaling when using lower render resolutions #4777

Closed
Firlaev-Hans opened this issue May 23, 2022 · 3 comments

Comments

@Firlaev-Hans
Copy link

Description

On my low end laptop, STK doesn't run well at 1080p unless I disable the advanced graphics pipeline, but then the game looks absolutely horrible.
So instead I turned down the render resolution to 50% and left the fancy graphics turned on, which looks significantly nicer, but of course everything is a bit blocky now at this low resolution.

Implementing AMD FidelityFX Super Resolution 1.0 to upscale the image when the render resolution is below 100% should be simple enough to do (they officially support only DX11/12 and Vulkan but OpenGL should work too).
It would greatly enhance the experience for players on low end devices like this as it could look much better than the current upscaler and the performance impact is minimal.

Alternatively, NVIDIA Image Scaling could also be used, which works in much the same way and produces similar results (note that I'm not talking about DLSS which is not open source and harder to implement).
FSR 2.0 could also be an option once it is open sourced soon™ but may also be harder to implement than FSR 1.0, though it would offer even better looking images at even lower render resolutions.

Configuration

STK release version: 1.3

STK Source (PPA, distribution package, official binary, etc.): Flatpak

System: Fedora 36 x86_64

Graphics card: Integrated Radeon Vega 3 graphics

CPU: AMD Ryzen 3200U

Additional Information

FidelityFX Super Resolution on GitHub

Integration Documentation for FSR 1.0

NVIDIAs alternative open source upscaler

@qwertychouskie
Copy link
Contributor

This would be a nice upgrade, hopefully with the Vulkan renderer this can be included.

@Benau
Copy link
Contributor

Benau commented Aug 26, 2022

Judging from the code of AMD FSR I don't think it's conservative enough to use it for all platforms we support (namely moltenvk or android which has weaker shader support)

@Benau Benau closed this as completed Aug 26, 2022
@Firlaev-Hans
Copy link
Author

Judging from the code of AMD FSR I don't think it's conservative enough to use it for all platforms we support (namely moltenvk or android which has weaker shader support)

Fair point but I still would have liked to see this implemented as an optional feature (which could simply be disabled on some platforms). I'd assume most players are on Linux or Windows anyways.
But if you don't want to implement it regardless, I guess that's fine. Current upscaler + anti-aliasing doesn't look too bad. FSR would just be a nice enhancement for those of us that can use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants