Re-merge swift lint #18
Conversation
- Lots of style changes to keep in line with swiftlint. It now runs the swiftlint file in the root of the folder on build. - Split some types into dedicated files. This is "in progress".
|
👋 Hey @yusuftor! Great job so far! We merged in your changes but ran into errors when trying to run the sample app. We looked into it and realized that you had changed the names of the two variables in Would you mind double checking your changes work correctly in the sample app? We'll do a testing push once they're ready but some of the simple cases will demonstrate this issue. Don't worry about the super nuanced cases we can run those together, just a few smoke test ones. |
|
Thanks! Yes this hasn’t been tested with the test app yet so shouldn’t be merged with master just yet. Good spot on that one and it’s simple to fix. Will do a run through to see if there are any other codables I’ve accidentally changed too. |
Added CodingKeys to Product
No description provided.