Fixes crash if you tried to save an object that didn't conform to NSS…

…ecureCoding in user attributes
superwall · Aug 18, 2023 · 7ed0ef2 · 7ed0ef2
1 parent 1d33675
commit 7ed0ef2
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,7 +12,8 @@ The changelog for `SuperwallKit`. Also see the [releases](https://github.com/sup
 ### Fixes
 
 - Fixes rare issue when using limits on a campaign rule. If a paywall encountered an error preventing it from being presented, it may still have been counted as having been presented. This would then have affected future paywall presentation requests underneath the same rule.
-- Fixes issue where resources weren't being accessed correctly when installing the SDK via CocoaPods.
+- Fixes issue where assets weren't being accessed correctly when installing the SDK via CocoaPods.
+- Fixes crash if you tried to save an object that didn't conform to NSSecureCoding in user attributes.
 
 ## 3.3.0
 

diff --git a/Sources/SuperwallKit/Paywall/View Controller/PaywallViewController.swift b/Sources/SuperwallKit/Paywall/View Controller/PaywallViewController.swift
@@ -740,7 +740,7 @@ extension PaywallViewController {
     if isSafariVCPresented {
       return
     }
-    Task(priority: .utility) {
+    Task {
       await trackClose()
     }
 

diff --git a/Sources/SuperwallKit/Storage/Cache/Cache.swift b/Sources/SuperwallKit/Storage/Cache/Cache.swift
@@ -139,7 +139,17 @@ class Cache {
       return
     }
 
-    let data = NSKeyedArchiver.archivedData(withRootObject: value)
+    guard let data = try? NSKeyedArchiver.archivedData(
+      withRootObject: value,
+      requiringSecureCoding: true
+    ) else {
+      Logger.debug(
+        logLevel: .warn,
+        scope: .cache,
+        message: "Could not write object that doesn't conform to NSSecureCoding to cache."
+      )
+      return
+    }
     memCache.setObject(data as AnyObject, forKey: keyType.key as AnyObject)
 
     writeDataToDisk(
@@ -163,7 +173,17 @@ class Cache {
       return
     }
 
-    let archivedData = NSKeyedArchiver.archivedData(withRootObject: data)
+    guard let archivedData = try? NSKeyedArchiver.archivedData(
+      withRootObject: data,
+      requiringSecureCoding: true
+    ) else {
+      Logger.debug(
+        logLevel: .warn,
+        scope: .cache,
+        message: "Could not write object that doesn't conform to NSSecureCoding to cache."
+      )
+      return
+    }
     memCache.setObject(archivedData as AnyObject, forKey: keyType.key as AnyObject)
 
     writeDataToDisk(