Feature/add internal purchase controller #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created an InternalPurchaseController. This coordinates the purchasing between provided purchase controllers and the internal purchasing mechanism. - Removed StoreKitCoordinator and removed redundant files like PurchaseManager. - Verification now happens before finishing a product. - No longer checks for restored product after purchase. This means if someone repurchases a product they already have, it'll count as a transaction_complete. This shouldn't be happening anyway, but something to consider.
- Stops ASN1 files from being public/open. - Fixes tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
InternalPurchaseController. This is responsible for figuring out whether to use a developer-provided purchase controller, or using its ownproductPurchaserwhen purchasing/restoring. Minimised the use ofhasPurchaseControllerthroughout the SDK by calling things directly in the purchase controller. Setting of the subscription status also happens inside the purchase controller.PurchaseController.Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.swiftlintin the main directory and fixed any issues.