Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.4.1 #178

Merged
merged 8 commits into from
Sep 29, 2023
Merged

v3.4.1 #178

merged 8 commits into from
Sep 29, 2023

Conversation

yusuftor
Copy link
Collaborator

@yusuftor yusuftor commented Sep 29, 2023

Changes in this pull request

  • Fixes issue where multiple events registered in quick succession may not be performed in serial, resulting in unexpected paywalls.
  • Fixes issue where transaction data wouldn't be available for those who are using a purchase controller.

Checklist

  • All unit tests pass.
  • All UI tests pass.
  • Demo project builds and runs.
  • I added/updated tests or detailed why my change isn't tested.
  • I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
  • I have run swiftlint in the main directory and fixed any issues.
  • I have updated the SDK documentation as well as the online docs.
  • I have reviewed the contributing guide

- Implicit events also run in serial.
- internallyPresent code now runs as part of the function rather than within a separate task. It doesn't return a publisher - this must be passed to it and setup beforehand.
- Adds a Queue data structure to make FIFO more efficient.
- All register calls are no longer wrapped in their own task blocks to avoid racing.
Removed `internalPresentingViewController` from PaywallViewController as that isn't used.
@yusuftor yusuftor merged commit 62426d5 into master Sep 29, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant