build: migrate backup stack to cdk #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peermuellerxw
had a problem deploying
to
pipeline01
GitHub Actions
Failure
peermuellerxw
had a problem deploying
to
pipeline01
GitHub Actions
Failure
peermuellerxw
had a problem deploying
to
pipeline01
GitHub Actions
Failure
peermuellerxw
had a problem deploying
to
pipeline01
GitHub Actions
Failure
peermuellerxw
had a problem deploying
to
pipeline01
GitHub Actions
Failure
peermuellerxw
had a problem deploying
to
pipeline01
GitHub Actions
Failure
peermuellerxw
had a problem deploying
to
pipeline01
GitHub Actions
Failure
peermuellerxw
had a problem deploying
to
pipeline01
GitHub Actions
Failure
peermuellerxw
had a problem deploying
to
pipeline01
GitHub Actions
Failure
peermuellerxw
had a problem deploying
to
pipeline01
GitHub Actions
Failure
peermuellerxw
had a problem deploying
to
pipeline01
GitHub Actions
Failure
peermuellerxw
had a problem deploying
to
pipeline01
GitHub Actions
Failure
peermuellerxw
had a problem deploying
to
pipeline01
GitHub Actions
Failure
peermuellerxw
had a problem deploying
to
pipeline01
GitHub Actions
Failure
acarlton
reviewed
May 22, 2024
| raise Exception | ||
|
|
||
|
|
||
| def policy_attached(policy_id): |
There was a problem hiding this comment.
It would feel a little more readable to me to break this statement into more, separated lines.
There was a problem hiding this comment.
I agree. I just copied this code from the existing inline lambdas. The next step I want to take is to refactor this functionality as meanwhile AWS Backup is capable to do the things we want without requiring special tags. #284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #504