Skip to content

Commit

Permalink
#31 Fix Rekit cli -u not work issue.
Browse files Browse the repository at this point in the history
  • Loading branch information
@supnate
supnate committed Jul 12, 2017
1 parent ac575f7 commit e131b7a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions bin/rekit.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ addCmd.addArgument(['--connect', '-c'], {
addCmd.addArgument(['--url-path', '-u'], {
help: 'The url path added to react router config. Only used for page/component.',
defaultValue: '$auto',
dest: 'urlPath',
});

addCmd.addArgument(['--async', '-a'], {
Expand Down

5 comments on commit e131b7a

@vale1534
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here urlPath defaults to be $auto , how can I disable it, i.e. I don't want to add to the router config?

@supnate
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, it's a good point. Using rekit-portal for now to create pure components without route config. I will fix cli soon. Thanks!

@supnate
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed default value '$auto' from cli in Rekit 2.0.5. Now it just creates just components without routing rules when no '-u' arg.

@vale1534
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@supnate
Super fan of rekit, you are my hero.
I am trying to start my personal site centered on rekit, any suggestion?

@supnate
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wenris ! You site looks nice and I'm very glad to see you would share practice on Rekit. If you have finished some articles, share links on juejin.im and segmentfault.com so that more people could see it. However I've not seen many Rekit real cases, if you begin to use it in real projects, I'm also looking forward to seeing your feedback. Thanks!

Please sign in to comment.