Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 did not set binary correct permission #377

Closed
billzhuang opened this issue Apr 10, 2024 · 4 comments · Fixed by #378
Closed

v4 did not set binary correct permission #377

billzhuang opened this issue Apr 10, 2024 · 4 comments · Fixed by #378

Comments

@billzhuang
Copy link

hi,
after use v4, my gh action report can not find the binary, which did not happen in v3

@billzhuang
Copy link
Author

billzhuang commented Apr 10, 2024

      - name: Install kubectl-neat-diff
        uses: supplypike/setup-bin@v3
        with:
          uri: 'https://github.com/sh0rez/kubectl-neat-diff/releases/download/v0.2.0/kubectl-neat-diff-linux-amd64'
          name: 'kubectl-neat-diff'
          version: 'v0.2.0'

      - name: debug
        run: |
          echo $PATH
          ls -al /opt/hostedtoolcache/kubectl-neat-diff/0.2.0/x64

return

Run echo $PATH
/opt/hostedtoolcache/kubectl-neat-diff/0.2.0/x64:/opt/hostedtoolcache/node/20.12.1/x64/bin:/snap/bin:/home/runner/.local/bin:/opt/pipx_bin:/home/runner/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
total 23164
drwxr-xr-x+ 2 runner docker 4096 Apr 10 03:45 .
drwxrwxrwx+ 3 runner docker 4096 Apr 10 03:45 ..
-rw-r--r--+ 1 runner docker 23711744 Apr 10 03:45 kubectl-neat-diff

looks like chmod failed

@billzhuang billzhuang changed the title v4 did not put binary in $PATH v4 did not set binary correct permission Apr 10, 2024
@anagyzambo-kx
Copy link

I think the change from chmodr to fs.chmod() is not a drop-in replacement as chmodr works recursively on the path whereas fs.chmod() works on a single file system entity.

See: https://www.npmjs.com/package/chmodr

@christophkloeffel
Copy link

+1
I also experience this issue.

@HarryGogonis
Copy link
Contributor

Good catch, should have left chmodr alone. Will have a fix asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants