Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review NTT code #1

Closed
SuprDewd opened this issue Dec 2, 2016 · 1 comment
Closed

Review NTT code #1

SuprDewd opened this issue Dec 2, 2016 · 1 comment
Labels
bug

Comments

@SuprDewd
Copy link
Owner

SuprDewd commented Dec 2, 2016

Currently the NTT code seems to be using any primitive root, while it should be using a (2^k)-th root of unity. Check if this is indeed a bug, then fix it, and test it.
@SuprDewd SuprDewd added the bug label Dec 2, 2016
@SuprDewd
Copy link
Owner Author

SuprDewd commented Dec 2, 2016

Never mind, I missed this line of code:
https://github.com/SuprDewd/CompetitiveProgramming/blob/master/code/mathematics/ntt.cpp#L19

@SuprDewd SuprDewd closed this as completed Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SuprDewd