Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Parsers to separate classes #16

Closed
supremebeing7 opened this issue Jun 16, 2016 · 0 comments
Closed

Extract Parsers to separate classes #16

supremebeing7 opened this issue Jun 16, 2016 · 0 comments

Comments

@supremebeing7
Copy link
Owner

There is already the Toggl::IssueKeyParser, but there should probably be one parser for a Toggl entry that returns all of the attributes needed. Currently, a lot of the parsing happens in JIRA::WorkLogger, but this is bad. WorkLogger should be agnostic of all parsing - it should receive just an array of time entries with the attributes it needs (description, comment, issue key, start time, duration).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant