Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PL-1742 Proposed new PR template for all Portals repos (including SureUI) #4

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

heath-sureify
Copy link
Collaborator

@heath-sureify heath-sureify commented Feb 22, 2024

Description (Why we're making the change)

We need to expand the scope of what's expected with a PR review and clarify some of the prompts.

What's changed? (Summary of code change)

Update default PR template

Jira Link(s)

https://sureify.atlassian.net/browse/PL-1742

Demo / Screen Shot (as applicable)

n/a

PR Author Checklist

Please consider every checkbox -- if it's done OR not applicable, check the box!

  • Unit tests added/updated
  • Assigned corresponding reviewers or notified in Slack
  • Updated README
  • Updated library CHANGELOG with
    • Environment Variables added/changed
    • Secrets added/changed
    • Feature Flags added/changed
  • Updated Test data and/or Demo data
  • Updated Postman collection for any API additions/changes
  • For CC-SDK or SureUI library changes, added a Jira subtask for updating EmptyCo

Author Notes

  • If the PR is not yet ready to be reviewed Create a Draft PR or add the Do Not Merge label
  • If a reviewer comments on something that could have been caught by a lint rule, either add that rule to the linter, or create a Jira ticket to add it.

Reviewer Notes

If the PR doesn't meet the above standards 👎 please add a review to "Request changes".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant