forked from apache/druid
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
More error reporting and stats for ingestion tasks (apache#5418)
* Add more indexing task status and error reporting * PR comments, add support in AppenderatorDriverRealtimeIndexTask * Use TaskReport instead of metrics/context * Fix tests * Use TaskReport uploads * Refactor fire department metrics retrieval * Refactor input row serde in hadoop task * Refactor hadoop task loader names * Truncate error message in TaskStatus, add errorMsg to task report * PR comments
- Loading branch information
Showing
87 changed files
with
4,085 additions
and
615 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
/* | ||
* Licensed to Metamarkets Group Inc. (Metamarkets) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. Metamarkets licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package io.druid.indexer; | ||
|
||
public enum IngestionState | ||
{ | ||
NOT_STARTED, | ||
DETERMINE_PARTITIONS, | ||
BUILD_SEGMENTS, | ||
COMPLETED | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/* | ||
* Licensed to Metamarkets Group Inc. (Metamarkets) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. Metamarkets licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package io.druid.indexer; | ||
|
||
import java.util.List; | ||
import java.util.Map; | ||
|
||
public interface TaskMetricsGetter | ||
{ | ||
List<String> getKeys(); | ||
Map<String, Number> getTotalMetrics(); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
/* | ||
* Licensed to Metamarkets Group Inc. (Metamarkets) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. Metamarkets licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package io.druid.indexer; | ||
|
||
import com.google.common.collect.Maps; | ||
|
||
import java.util.Map; | ||
|
||
public class TaskMetricsUtils | ||
{ | ||
public static final String ROWS_PROCESSED = "rowsProcessed"; | ||
public static final String ROWS_PROCESSED_WITH_ERRORS = "rowsProcessedWithErrors"; | ||
public static final String ROWS_UNPARSEABLE = "rowsUnparseable"; | ||
public static final String ROWS_THROWN_AWAY = "rowsThrownAway"; | ||
|
||
public static Map<String, Object> makeIngestionRowMetrics( | ||
long rowsProcessed, | ||
long rowsProcessedWithErrors, | ||
long rowsUnparseable, | ||
long rowsThrownAway | ||
) | ||
{ | ||
Map<String, Object> metricsMap = Maps.newHashMap(); | ||
metricsMap.put(ROWS_PROCESSED, rowsProcessed); | ||
metricsMap.put(ROWS_PROCESSED_WITH_ERRORS, rowsProcessedWithErrors); | ||
metricsMap.put(ROWS_UNPARSEABLE, rowsUnparseable); | ||
metricsMap.put(ROWS_THROWN_AWAY, rowsThrownAway); | ||
return metricsMap; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,92 @@ | ||
/* | ||
* Licensed to Metamarkets Group Inc. (Metamarkets) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. Metamarkets licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package io.druid.utils; | ||
|
||
import com.google.common.base.Preconditions; | ||
|
||
/** | ||
* A circular buffer that supports random bidirectional access. | ||
* | ||
* @param <E> Type of object to be stored in the buffer | ||
*/ | ||
public class CircularBuffer<E> | ||
{ | ||
public E[] getBuffer() | ||
{ | ||
return buffer; | ||
} | ||
|
||
private final E[] buffer; | ||
|
||
private int start = 0; | ||
private int size = 0; | ||
|
||
public CircularBuffer(int capacity) | ||
{ | ||
Preconditions.checkArgument(capacity > 0, "Capacity must be greater than 0."); | ||
buffer = (E[]) new Object[capacity]; | ||
} | ||
|
||
public void add(E item) | ||
{ | ||
buffer[start++] = item; | ||
|
||
if (start >= buffer.length) { | ||
start = 0; | ||
} | ||
|
||
if (size < buffer.length) { | ||
size++; | ||
} | ||
} | ||
|
||
/** | ||
* Access object at a given index, starting from the latest entry added and moving backwards. | ||
*/ | ||
public E getLatest(int index) | ||
{ | ||
Preconditions.checkArgument(index >= 0 && index < size, "invalid index"); | ||
|
||
int bufferIndex = start - index - 1; | ||
if (bufferIndex < 0) { | ||
bufferIndex = buffer.length + bufferIndex; | ||
} | ||
return buffer[bufferIndex]; | ||
} | ||
|
||
/** | ||
* Access object at a given index, starting from the earliest entry added and moving forward. | ||
*/ | ||
public E get(int index) | ||
{ | ||
Preconditions.checkArgument(index >= 0 && index < size, "invalid index"); | ||
|
||
int bufferIndex = (start - size + index) % buffer.length; | ||
if (bufferIndex < 0) { | ||
bufferIndex += buffer.length; | ||
} | ||
return buffer[bufferIndex]; | ||
} | ||
|
||
public int size() | ||
{ | ||
return size; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.