Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: move <4 requirement #24

Merged
merged 1 commit into from
Feb 15, 2023
Merged

setup: move <4 requirement #24

merged 1 commit into from
Feb 15, 2023

Conversation

gsilvapt
Copy link
Contributor

Mistakenly the < 4 was put forth in Python version when it should have been Django's.
Plus, while on it, solved FIXME item and moved the dependency to optional and adding in the docs for users to install the optional dependency if they want to use it.

@gsilvapt gsilvapt added the enhancement New feature or request label Feb 15, 2023
@gsilvapt gsilvapt changed the title setup: move <4 requirement and add optional dep setup: move <4 requirement Feb 15, 2023
Mistakenly the < 4 was put forth in Python version when
it should have been Django's.
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Base: 88.49% // Head: 88.49% // No change to project coverage 👍

Coverage data is based on head (628cc5a) compared to base (21b48b4).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #24   +/-   ##
========================================
  Coverage    88.49%   88.49%           
========================================
  Files           14       14           
  Lines          513      513           
========================================
  Hits           454      454           
  Misses          59       59           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gsilvapt gsilvapt requested review from a team, cojoeu and tcppb and removed request for a team February 15, 2023 18:24
@gsilvapt gsilvapt merged commit 808a887 into develop Feb 15, 2023
@gsilvapt gsilvapt deleted the misc-typo_in_setup_cfg branch February 15, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants