Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code smells #30

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Fix code smells #30

merged 3 commits into from
Mar 20, 2023

Conversation

fopina
Copy link
Contributor

@fopina fopina commented Mar 19, 2023 •
edited

Address code smells reported by sonar to help with #27

@fopina fopina requested a review from a team as a code owner March 19, 2023 16:57
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2023 •
edited

Codecov Report

Patch coverage: 95.65% and project coverage change: +0.51 🎉

Comparison is base (21c9383) 88.49% compared to head (d7ccd52) 89.01%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop      #30      +/-   ##
===========================================
+ Coverage    88.49%   89.01%   +0.51%     
===========================================
  Files           14       14              
  Lines          513      528      +15     
===========================================
+ Hits           454      470      +16     
+ Misses          59       58       -1
Impacted Files Coverage Δ
dkron/migrations/0001_initial_20210729.py 100.00% <ø> (ø)
dkron/migrations/0002_job_retries.py 100.00% <ø> (ø)
dkron/utils.py 86.15% <95.00%> (+1.01%) ⬆️
dkron/management/commands/run_dkron.py 91.22% <100.00%> (+2.51%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Mar 19, 2023 •
edited

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fopina fopina mentioned this pull request Mar 20, 2023
Open
@fopina fopina merged commit 77a9685 into develop Mar 20, 2023
@DDuarte DDuarte deleted the fix/code_smells branch February 16, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsilvapt gsilvapt gsilvapt approved these changes

@bogdanoniga bogdanoniga Awaiting requested review from bogdanoniga bogdanoniga is a code owner automatically assigned from surface-security/core

@tcppb tcppb Awaiting requested review from tcppb tcppb is a code owner automatically assigned from surface-security/core

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fopina @codecov-commenter @gsilvapt