drop the need for "shell magic" in dkron run_async with a 'proxy' command #31

fopina · 2023-03-19T19:04:19Z

Make use of a proxy command to call run_async commands with call_command() dropping the need for shell magic to handle escaping/invalid characters, dashes for flags, etc.

This is mostly backward compatible except for the cases where callers implemented hacks/workarounds to escape the characters themselves... But that should be easy to fix and the proper approach as, again, those were workarounds/hacks...

PR tested with the new unit test and also, for integration, manually tested with

$ ./manage.py shell -c 'from dkron.utils import run_async; run_async("shell", command="import time;print(1);time.sleep(2);print(2)")'

(after starting dkron server run_dkron)

This PR fixes #15

github-advanced-security · 2023-03-19T19:04:51Z

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

codecov-commenter · 2023-03-20T23:33:17Z

Codecov Report

Patch coverage: 96.55% and project coverage change: +1.14 🎉

Comparison is base (21c9383) 88.49% compared to head (7bcc4f2) 89.64%.

❗ Current head 7bcc4f2 differs from pull request most recent head 24e2db5. Consider uploading reports for the commit 24e2db5 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop      #31      +/-   ##
===========================================
+ Coverage    88.49%   89.64%   +1.14%     
===========================================
  Files           14       15       +1     
  Lines          513      541      +28     
===========================================
+ Hits           454      485      +31     
+ Misses          59       56       -3

Impacted Files	Coverage Δ
dkron/migrations/0001_initial_20210729.py	`100.00% <ø> (ø)`
dkron/migrations/0002_job_retries.py	`100.00% <ø> (ø)`
dkron/utils.py	`86.84% <94.59%> (+1.69%)`	⬆️
dkron/management/commands/run_dkron.py	`91.22% <100.00%> (+2.51%)`	⬆️
...ron/management/commands/run_dkron_async_command.py	`100.00% <100.00%> (ø)`