Support function components #473
Conversation
* Support local and remote function components * Support recursive components by translating them into function components
* No support for slots * No support for contexts * Don't validate args
| @@ -1223,4 +1294,17 @@ defmodule Surface.Compiler do | |||
|
|
|||
| IOHelper.compile_error(message, file, line) | |||
| end | |||
|
|
|||
| defp handle_convert_node_to_ast_error(name, error, meta) do | |||
| caller_component_type = Module.get_attribute(meta.caller.module, :component_type) | ||
| quote generated: true do | ||
| component( | ||
| &(unquote(Macro.var(fun, __MODULE__)) / 1), |
There was a problem hiding this comment.
The spacing here looks odd, but I assume that's not an actual issue?
There was a problem hiding this comment.
Yeah, that's not an issue. I find that ugly too but that's the way the formatter handles it so there's not much we can do about it, I guess :)
| @@ -0,0 +1,43 @@ | |||
| defmodule Surface.Components.Component do | |||
There was a problem hiding this comment.
Should we add a 'props' prop to allow passing a map of props? My thinking is that otherwise users would get warnings about unknown props for this component
There was a problem hiding this comment.
They shouldn't get any warning but they can also use {...}. However, I'm not sure yet if that API is the best one. I'll create some tests for those cases and think how we can improve it.
| @@ -0,0 +1,298 @@ | |||
| defmodule Surface.Components.ComponentComponentTest do | |||
There was a problem hiding this comment.
| defmodule Surface.Components.ComponentComponentTest do | |
| defmodule Surface.Components.DynamicComponentTest do |
There was a problem hiding this comment.
@Malian good catch! I was also thinking about changing the namespace from Surface.Components.Component to Surface.Components.Dynamic.Component as we still gonna have to implement a Surface.Components.Dynamic.LiveComponent in the near future. Since those built-in components are automatically aliased, I don't mind the larger name. WDYT?
msaraiva
force-pushed
the
ms-function-component
branch
from
5d6aadb
to
05b3e32
Compare
| @@ -0,0 +1,43 @@ | |||
| defmodule Surface.Components.Component do | |||
There was a problem hiding this comment.
Going by the file name:
| defmodule Surface.Components.Component do | |
| defmodule Surface.Components.DynamicComponent do |
There was a problem hiding this comment.
But in the tests it seems you named it Component on purpose, it does read nicer 🤔
Also closes #343 and #24.