Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

fix(SNP-400): Updates build badge route. #7

Merged
merged 8 commits into from
Apr 3, 2024

Conversation

ruinalsu
Copy link

@ruinalsu ruinalsu commented Apr 24, 2023

Changes

Checklist for self-check

  • Commits and PRs have been filed according to the rules on the project.
  • The author is marked as an assigne and assigned mandatory reviewers.
  • Required labels marked
  • Specified related tasks and/or related PRs.
  • Specified Changes.
  • Attached videos/screenshots demonstrating the fix/feature.
  • All unspecified fields in the PR description deleted.
  • New code covered by tests.

Checklist for reviewers

  • CI passed successfully (with a green check mark).
  • PR is atomic, by volume no more than 400 (+-) corrected lines (not including codogen).

Design:

  • System design corresponds to the agreements on structure and architecture on the project.
  • The code is decomposed into necessary and sufficient components.

Functionality:

  • The code solves the problem.
  • Any changes to the user interface are reasonable and look good.

Complexity:

  • The code is clear, easy to read, functions are small, no more than 50 lines.
  • The logic is not overcomplicated, there is no overengineering (no code sections that may be needed in the future, but no one knows about it).

Tests:

  • Updated or added tests for mandatory components.
  • The tests are correct, helpful, and well designed/developed.

Naming:

  • The naming of variables, methods, classes and other components is understandable.

Comments:

  • The comments are understandable and helpful.

Documentation:

  • All labels are correct
  • Technical documentation updated (after approval, updates last reviewer).

@ruinalsu ruinalsu added the bug Something isn't working label Apr 24, 2023
@ruinalsu ruinalsu self-assigned this Apr 24, 2023
@danyaao danyaao requested review from ekinsdrow and removed request for dshevchenkoo April 3, 2024 07:28
@danyaao danyaao assigned danyaao and unassigned ruinalsu Apr 3, 2024
Copy link

@ekinsdrow ekinsdrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image (

fix: flutter format to dart format
@danyaao danyaao merged commit 53a074f into main Apr 3, 2024
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants