Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-OS-indepdent path separators #28

Closed
baconpaul opened this issue Dec 30, 2020 · 3 comments
Closed

non-OS-indepdent path separators #28

baconpaul opened this issue Dec 30, 2020 · 3 comments

Comments

@baconpaul
Copy link
Contributor

No description provided.

@djtuBIG-MaliceX
Copy link
Contributor

Have to use std::replace(). As with #59 I opted to use that in combination with fs::absolute() as a form of normalisation. Might be worth generalising when passing paths between string_to_path() and path_to_string() as a global sanitisation operation. Overhead introduced does not affect real-time performance and is likely to only take place during bank/sample load operations.

@rudeog
Copy link
Collaborator

rudeog commented Jan 27, 2021

Back when I was fluffing up the configuration.cpp I did some work on some path functions (see functions ending in _path). It might be a good idea to have some of this functionality in utilities, and we could add functionality for slash conversion.

@baconpaul
Copy link
Contributor Author

I'm going to close this since I think the solution is to use fs::path operator/ everywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants