Format: SFZ #59
Comments
djtuBIG-MaliceX
added a commit
to djtuBIG-MaliceX/shortcircuit-xt
that referenced
this issue
Jan 23, 2021
djtuBIG-MaliceX
added a commit
to djtuBIG-MaliceX/shortcircuit-xt
that referenced
this issue
Jan 23, 2021
… SFZ now. Just need to apply 'default behaviours' as applicable to SFZ 1.0 for this particular barebones use case (using Polyphone as reference)
djtuBIG-MaliceX
added a commit
to djtuBIG-MaliceX/shortcircuit-xt
that referenced
this issue
Jan 23, 2021
baconpaul
pushed a commit
that referenced
this issue
Jan 26, 2021
Subordinate commits include: * - Start work on sfz. Assessment so far: Will need to re-write load_sfz() anyway due to it making poor assumptions of how to handle SFZ v1 files. pseudocode written. * Progress! #59 - WAV samples appear to be loading via SFZ now. Just need to apply 'default behaviours' as applicable to SFZ 1.0 for this particular barebones use case (using Polyphone as reference) * Fix SFZ crossfade zones since being initialized per-zone now. TODO: figure out how to deal with infinite loop cases due to people writing malformed SFZ opcodes... * Fixed the infinite loop during opcode parsing... next: what's up with GUI freezing when loading certain SFZs? * fix default binding of default low/hi keys where root key is not specified. * use platform-agnostic separator. again, only sfZed (sfz 1.0) file maps work. * super super dodgy workaround for unquoted paths with spaces for now, but it works... * Added my own test samples with some tweaks for exercising sfz behaviours. No regtests yet. * WIP: fixing a bug with quoted value handling. * Path handling tweaks - now The Open Source drumkit SFZ samples load properly it seems. * Fixed sample loading with spaces and a bunch of zone range issues. Some unrelated issues involving sample loop segfaulting and JUCE rendering issues outstanding but...it works! * Add SFZ regtests, correction to drum SFZ. * fix max() * fix regtests for lin/mac (likely playback timing differences) * - use `fs::canonical()` instead of `fs::absolute()` - tested on WSL2 Ubuntu 20.04 * attempt 3... absolute seemed to work better after all? trying `std::replace`
|
Partial support for SFZ 1.0 + |
|
Happy to close it. Thank you! |
mvf
pushed a commit
to mvf/shortcircuit3
that referenced
this issue
Aug 13, 2021
Subordinate commits include: * - Start work on sfz. Assessment so far: Will need to re-write load_sfz() anyway due to it making poor assumptions of how to handle SFZ v1 files. pseudocode written. * Progress! surge-synthesizer#59 - WAV samples appear to be loading via SFZ now. Just need to apply 'default behaviours' as applicable to SFZ 1.0 for this particular barebones use case (using Polyphone as reference) * Fix SFZ crossfade zones since being initialized per-zone now. TODO: figure out how to deal with infinite loop cases due to people writing malformed SFZ opcodes... * Fixed the infinite loop during opcode parsing... next: what's up with GUI freezing when loading certain SFZs? * fix default binding of default low/hi keys where root key is not specified. * use platform-agnostic separator. again, only sfZed (sfz 1.0) file maps work. * super super dodgy workaround for unquoted paths with spaces for now, but it works... * Added my own test samples with some tweaks for exercising sfz behaviours. No regtests yet. * WIP: fixing a bug with quoted value handling. * Path handling tweaks - now The Open Source drumkit SFZ samples load properly it seems. * Fixed sample loading with spaces and a bunch of zone range issues. Some unrelated issues involving sample loop segfaulting and JUCE rendering issues outstanding but...it works! * Add SFZ regtests, correction to drum SFZ. * fix max() * fix regtests for lin/mac (likely playback timing differences) * - use `fs::canonical()` instead of `fs::absolute()` - tested on WSL2 Ubuntu 20.04 * attempt 3... absolute seemed to work better after all? trying `std::replace`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reports of crashes on linux. Need some good test cases. @baconpaul has the plogue ones but those are flac inside which I don't think the SC3 code does today.
The text was updated successfully, but these errors were encountered: