Reverb 1 produces noise for polyphonic channels on patch load

[Miff-Real]

Appears to be specific to Windows, can be reproduced by a simple patch like so:

[baconpaul]

my rough guess here (but probably don't have time to look today) is on patch load the order of creating the poly channels is peculiar and i have a path through that which skips an init; and that init leave garbage in the buffers on windows; and that creates the noise.

But need to walk the code in poly mode to test that.

[baconpaul]

Ahh I think I see it. Can repro on mac if i do a little pathological thing and my fix fixes it.

Stay tuned... it might be an easy fix.

[baconpaul]

@Miff-Real can you test the nightly https://github.com/surge-synthesizer/surge-rack/releases/tag/Nightly

if it fixes it I can shuffle it into the library.

Thanks!

[Miff-Real]

Hmm, doesn't look like it, sorry 😞

[Miff-Real]

Checked it on the simple patch too just to make sure, and can still repro there too

[baconpaul]

Ok. Well that means I’ll have to boot windows and make a windows rack dev environment. That’s gonna be a bit…

wonder what it is gonna turn out to be