Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DnD or Load WT from file always switches osc type to Wavetable #3657

Closed
mkruselj opened this issue Jan 18, 2021 · 2 comments · Fixed by #3663
Closed

DnD or Load WT from file always switches osc type to Wavetable #3657

mkruselj opened this issue Jan 18, 2021 · 2 comments · Fixed by #3663
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone
1.8.1

Comments

@mkruselj
Copy link
Collaborator

Even if we had it set to Window. Uncool. Needs fix!

Thanks to Gone soft on KvR for report.
@mkruselj mkruselj added UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. Bug Report Item submitted using the Bug Report template labels Jan 18, 2021
@mkruselj mkruselj added this to the 1.9.0 milestone Jan 18, 2021
@baconpaul
Copy link
Collaborator

Oh ha yeah! We should obviously fix that. The intent was "make it use a wavetable oscillator" but not checking window first is rude :)

@mkruselj
Copy link
Collaborator Author

Ehehe :)

@baconpaul baconpaul modified the milestones: 1.9.0, 1.8.1 Jan 18, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Jan 18, 2021
@baconpaul
Oscilaltor Type Preserve on Wave/WT Drop/Load
be7720a 
If you are already on window or wavetable when you drop
or load a wave, don't force a change to wavetable.

Closes surge-synthesizer#3657
@baconpaul baconpaul mentioned this issue Jan 18, 2021
Merged
baconpaul added a commit that referenced this issue Jan 18, 2021
@baconpaul
Oscilaltor Type Preserve on Wave/WT Drop/Load (#3663)
e33f6bb 
If you are already on window or wavetable when you drop
or load a wave, don't force a change to wavetable.

Closes #3657
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
1.8.1
Development

Successfully merging a pull request may close this issue.

Oscillator type preserve on Wave/WT drop/load baconpaul/surge
2 participants
@mkruselj @baconpaul