Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overzealous hovers in oscillator select multiswitch #5801

Closed
mkruselj opened this issue Jan 19, 2022 · 8 comments · Fixed by #5890
Closed

Overzealous hovers in oscillator select multiswitch #5801

mkruselj opened this issue Jan 19, 2022 · 8 comments · Fixed by #5890
Labels
Bug Report Item submitted using the Bug Report template UI Issues related to UI look&feel UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone
Surge XT 1.1

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Jan 19, 2022 •
edited
Loading

hovers

And ONLY that one. All other multiswitches seem to be perfectly fine otherwise.
@mkruselj mkruselj added UI Issues related to UI look&feel UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. Bug Report Item submitted using the Bug Report template labels Jan 19, 2022
@mkruselj mkruselj added this to the Surge XT 1.1 milestone Jan 19, 2022
@mkruselj mkruselj mentioned this issue Feb 1, 2022
Closed
@mkruselj
Copy link
Collaborator Author

Something similar happens when dragging the scene select multibutton:

eeep

@mkruselj
Copy link
Collaborator Author

Aaaaaaaand same thing happens with envelope digital/analog mode button.

@baconpaul
Copy link
Collaborator

I bet I know what it is. Hold on.

@baconpaul
Copy link
Collaborator

surge/src/surge-xt/gui/widgets/MultiSwitch.cpp

Line 192 in 3e966c5

hoverSelection = sel;

If you comment out that line does it go away?

@mkruselj
Copy link
Collaborator Author

@baconpaul Nope, still happens.

@baconpaul
Copy link
Collaborator

huh ok lemme switch over to windows and see if i can find it then.

@baconpaul
Copy link
Collaborator

ahhhhhhhh what a pain
this happens because changing that value rebuilds the ui and that blows up the hover state
I know why but I am not sure what to fix yet

@baconpaul
Copy link
Collaborator

which in turn causes a focus gained but we don't have a mouse position so we fake one to set the hover on focus input. let me adjust that.

baconpaul added a commit to baconpaul/surge that referenced this issue Feb 14, 2022
@baconpaul
Fix switch drag/hover/ghost
5227f2e 
When you were dragging things whose value caused a rebuild
it went badly with hover state. Fix it all and clean it all up.
While at it, make the supplied data path work on windows too

Closes surge-synthesizer#5801
@baconpaul baconpaul mentioned this issue Feb 14, 2022
Merged
baconpaul added a commit that referenced this issue Feb 14, 2022
@baconpaul
Fix switch drag/hover/ghost (#5890)
4af3bf3 
When you were dragging things whose value caused a rebuild
it went badly with hover state. Fix it all and clean it all up.
While at it, make the supplied data path work on windows too

Closes #5801
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template UI Issues related to UI look&feel UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
Surge XT 1.1
Development

Successfully merging a pull request may close this issue.

Fix switch drag/hover/ghost baconpaul/surge
2 participants
@mkruselj @baconpaul