Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot focus the Favorite button #7399

Closed
mkruselj opened this issue Dec 15, 2023 · 0 comments · Fixed by #7467
Closed

Cannot focus the Favorite button #7399

mkruselj opened this issue Dec 15, 2023 · 0 comments · Fixed by #7467
Labels
Accessibility Issues related to making Surge more accessible Feature Request New feature request UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone
Surge XT 1.3.1

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Dec 15, 2023 •
edited by baconpaul

Navigating through the panes with focus debugger enabled, I cannot seem to be able to focus on the Favorite button in the Patch Selector. So we cannot right-click it either accessibly so that we get the list of favorites.

Additionally, it would be great if we had a search query that would list all favorites, like CAT or CATEGORY = Fav or Favorites. (bp moved this to #7465)
@mkruselj mkruselj added UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. Bug Report Item submitted using the Bug Report template Accessibility Issues related to making Surge more accessible labels Dec 15, 2023
@mkruselj mkruselj added this to the Surge XT 1.3.1 milestone Dec 15, 2023
@mkruselj mkruselj added Feature Request New feature request and removed Bug Report Item submitted using the Bug Report template labels Dec 15, 2023
@baconpaul baconpaul mentioned this issue Jan 22, 2024
Open
baconpaul added a commit to baconpaul/surge that referenced this issue Jan 22, 2024
@baconpaul
Patch Selector Favorites/Find button Accessible; Focusable
ea7830a 
The favorites and find button were funky - drawn in place.
They are still a bit funky - drawn in place with a focusable
accessible overlay - but that's just to avoid reworking the draw
code. This makes them accessible, focusable, and so on. Moreover
the accessible name of the favorites button indicates whether a
patch is a favorite or not.

Closes surge-synthesizer#7399
@baconpaul baconpaul mentioned this issue Jan 22, 2024
Merged
baconpaul added a commit that referenced this issue Jan 22, 2024
@baconpaul
Patch Selector Favorites/Find button Accessible; Focusable (#7467)
92df8fd 
The favorites and find button were funky - drawn in place.
They are still a bit funky - drawn in place with a focusable
accessible overlay - but that's just to avoid reworking the draw
code. This makes them accessible, focusable, and so on. Moreover
the accessible name of the favorites button indicates whether a
patch is a favorite or not.

Closes #7399
This was referenced Mar 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accessibility Issues related to making Surge more accessible Feature Request New feature request UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
Surge XT 1.3.1
Development

Successfully merging a pull request may close this issue.

Patch Selector Favorites/Find button Accessible; Focusable baconpaul/surge
1 participant
@mkruselj