Fix problem with FX Unit Typein and OSC #7704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Messages through trigger update used the old value to repaint the display, which caused issues with OSC and other automation paths (less so) 2. Type-ins via the parameter mechanism when using the ported-to-sst-effects effects with param metadata worked with in-app typeins but not with from-daw typeins since string to value onto in that case wrote the wrong item. Remediate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages through trigger update used the old value to repaint the display, which caused issues with OSC and other automation paths (less so)
Type-ins via the parameter mechanism when using the ported-to-sst-effects effects with param metadata worked with in-app typeins but not with from-daw typeins since string to value onto in that case wrote the wrong item. Remediate.