Fix: Fixed issue query on observer #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issues with store_mongodb when using legacy, due to cursor on adds on queryOptions not query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue in question
When using
viewdb_persistence_store_mongodbwithout oplogListener we use Legacy (viewdb observer) this causes issue since mongodb cursor sets is options like: limit, sort and skip inqueryOptionswhich gets never used on our observer. Since our cursor in viewdb we set everything in thequeryparameters notqueryOptions.This gets fixed when we merge both
queryandqueryOptionsinto one object.