-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to chrome.storage API and 24 hour currency rate caching #6
base: master
Are you sure you want to change the base?
Conversation
Hey Zan, Thanks for putting this together, Did you test it? Anyway, I will also do a quick round of testing and will merge tomorrow... |
Hello, |
Okay. You can update the pull request..
|
OK, I fixed it. |
Hello, I tested it for few days and noticed only that settings weren't saved, but it all works now. |
Great.. I've been busy these weeks, Will push an update soon. |
One more thing I found that, The conversion from localstorage to storage api is too slow and stopping when I clicked options page. So, Few of the localstorage items stays there and some in the storage API. I need to click reload quite few times to make it convert fully. Do you have any idea why this is happening? |
@zan-gerden got my message? |
Yes I did, but currently I don't have much time and will fix this maybe next week. |
Sure, Tight schedule for all of us. :)
|
Title says it all :)