Exclude arm64 for macos #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`arm64` is not fully supported by all of the Rust dependencies. Until #52 is open and building Rust dependency with triple `aarm64-apple-darwin` continues to fail `arm64` will not be supported.
surpher
added
breaking change
This was referenced Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摑 Summary of Changes
arm64andarm64earchitectures for macOS are not yet fully (and painlessly) supported by all the tools and dependencies when dealing with PactSwift and specifically the Rustlibpact_mock_server.a. Building thelibpact_mock_server.abinary withaarch64-apple-darwintriple continues to fail. Asarm64is still scarce in the wild, I decided to exclude from valid architectures for macOS target for now.馃馃棐 Reviewer Notes
I'm keeping a close eye on the progress of
aarch64-apple-darwinavailability. As soon as it is available in the stable toolchain and building the dependencies succeeds, this will be reverted.馃敤 How To Test