Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nextjs tauri kit in README.md #40

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Conversation

reymom
Copy link
Contributor

@reymom reymom commented Oct 8, 2023

My contribution for the issue #35.

From the README.md: This starter kit provides a streamlined setup for developing a Tauri App + Next.js applications with an integrated SurrealDB database. It bridges the frontend with the backend using an ICP command layer following the JSON-RPC 2.0 format.

If there's something that should be improved, do let me know 👍

@phughk
Copy link
Contributor

phughk commented Oct 10, 2023

Hey! Thanks for writing this, it's great!

One comment about the readme - could you include the command to install the tauri CLI please?
cargo install --git https://github.com/tauri-apps/tauri --branch 1.x tauri-cli
Otherwise, I think it's really good thank you :)

Some things I would change as a personal preference (you absolutely don't have to, it's already at a high standard)

  • Have the models represent structs and their implementations only in the model module.
  • Have the storage moved outside of models, into something like persistence or repository, so that you have the separation of database operations from models.

Aside from that, it's perfect. Thanks as well for writing tests, they are a great way to get reassurance and learn from the starter kit!

Copy link
Contributor

@phughk phughk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great submission, thank you!

@reymom
Copy link
Contributor Author

reymom commented Oct 11, 2023

Thanks for the feedback! I already added the tauri-cli install command. I will also check that about the structure, I agree it looks a bit odd. I was trying to get a minimal organization and ended up mixing types-model-storage up.

@kearfy kearfy merged commit f4b666e into surrealdb:main Oct 24, 2023
1 check passed
@kearfy kearfy added the hacktoberfest-accepted Thanks for your contribution! label Oct 24, 2023
@kearfy
Copy link
Member

kearfy commented Oct 24, 2023

Apologies for the delayed merge here @reymom! Merged it now, thanks for your contribution!

@kearfy
Copy link
Member

kearfy commented Oct 24, 2023

Oh, I forgot to ask, but could you add a screenshot of your finished application in the Readme of your project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Thanks for your contribution!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants