Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add koa starter-kit #41

Merged
merged 3 commits into from
Oct 20, 2023
Merged

add koa starter-kit #41

merged 3 commits into from
Oct 20, 2023

Conversation

jerempy
Copy link
Contributor

@jerempy jerempy commented Oct 10, 2023

My contribution for the issue #35.

The starter-kit: https://github.com/jerempy/surrealdb-starter-koa

This is a REST API using koa.js and surrealDB as the database.

contains multiple methods on single endpoint with examples of request and responses

@kearfy
Copy link
Member

kearfy commented Oct 13, 2023

Hello @jerempy! Thanks for your Hacktoberfest contribution, we really appreciate your effort into our community!

I have one comment about your code, which has to do with these lines:

If I'm not mistaken, a Record ID for any record, also non-event records, can be passed there. Could you make it so that only event records can be passed there?

Thanks!

@jerempy
Copy link
Contributor Author

jerempy commented Oct 14, 2023

@kearfy thanks for the feedback! I made these changes, and also some other small improvements as well

@naisofly
Copy link
Contributor

Thank you @jerempy! Could you include a screenshot or GIF of your application running in the README of your project? Thanks!

@jerempy
Copy link
Contributor Author

jerempy commented Oct 18, 2023

@naisofly I added some screen shots 🙌

README.md Outdated Show resolved Hide resolved
@kearfy kearfy merged commit 3050823 into surrealdb:main Oct 20, 2023
1 check passed
@naisofly naisofly added the hacktoberfest-accepted Thanks for your contribution! label Oct 23, 2023
@naisofly
Copy link
Contributor

Hey @jerempy
Thank you for contributing to SurrealDB during Hacktoberfest 2023 🎉
Kindly send an email to community@surrealdb.com to coordinate the delivery of your SurrealDB swag! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Thanks for your contribution!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants