Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace composite index by two indexes for FTS #394

Merged
merged 9 commits into from
Mar 7, 2024

Conversation

emmanuel-keller
Copy link
Contributor

@emmanuel-keller emmanuel-keller commented Mar 7, 2024

Actually the documention is misleading

surrealdb/surrealdb#3530

In fact, the main usage of composite indexes is for unique indexes, when you want to ensure that there are not two records in the same table having the same composite content.

By extension, it is possible to build a composite index with FTS in SurrealDB, but that does not really make sense, as there is no possibility to query it. In a future release, we will clarify this behavior.

Copy link

netlify bot commented Mar 7, 2024

Deploy Preview for surrealdb-docs ready!

Name Link
🔨 Latest commit 6dc5a50
🔍 Latest deploy log https://app.netlify.com/sites/surrealdb-docs/deploys/65e99e30a1f1fa000858777a
😎 Deploy Preview https://deploy-preview-394--surrealdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Ekwuno
Ekwuno previously approved these changes Mar 7, 2024
@Ekwuno
Copy link
Contributor

Ekwuno commented Mar 7, 2024

@emmanuel-keller @timpratim we're taking the other versions out. Safe to just update 1.2.x

Co-authored-by: Pratim <pratim.bhosale@gmail.com>
emmanuel-keller and others added 3 commits March 7, 2024 10:56
Co-authored-by: Pratim <pratim.bhosale@gmail.com>
Co-authored-by: Pratim <pratim.bhosale@gmail.com>
Co-authored-by: Pratim <pratim.bhosale@gmail.com>
emmanuel-keller and others added 4 commits March 7, 2024 10:59
Co-authored-by: Pratim <pratim.bhosale@gmail.com>
Co-authored-by: Pratim <pratim.bhosale@gmail.com>
…h.mdx

Co-authored-by: Pratim <pratim.bhosale@gmail.com>
…h.mdx

Co-authored-by: Pratim <pratim.bhosale@gmail.com>
Copy link
Contributor

@timpratim timpratim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good now. Thank you for fixing this @emmanuel-keller

@Ekwuno Ekwuno merged commit 89fbc89 into main Mar 7, 2024
4 checks passed
@Ekwuno Ekwuno deleted the emmanuel/fix-fts-non-composite-index branch March 7, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants