expand generic type/lt impl #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Nice one @demfabris ! Out of interest how will the macro be applied/specified in the main surrealdb library? Is there any change needed there, or is it just the same as it is now? |
|
Its the same, no usage changes. |
|
Awesome! |
|
Is this PR ready to merge as is? |
|
Related: surrealdb/storekey#1 |
demfabris
force-pushed
the
support-generic-params
branch
from
c6f0647
to
ac19cac
Compare
|
Ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we simply add support for generic parameters and lifetimes so the expanded macro compiles successfully