-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logger added. #66
Logger added. #66
Conversation
Can we please use https://github.com/sirupsen/logrus instead? It has levels and already has all the functionality we need. Thanks for adding this though! |
I'm not sure about it, it says "Logrus is in maintenance-mode". |
I have used it in the past, but actually you are right. We should pick one of Zerolog seems to be an improvement on zap, and apex seems to be an integration on top of logging libraries. In that case I think we should use zerolog. What do you think? |
unit tests added.
Yeah, I agree I added zerolog implementation and some unit tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Some comments about errors and statefulnes
*.log added to .gitignore rawlogger func added for raw io.writer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Left some comments
channels added
Logger Added.
It was on TODO I wanted to complete it.