Fix sending too many fields on auth vars #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.
What is the motivation?
We were sending too many fields on auth vars, causing signin to silently fail. Additionally, we were checking for a
detailfield for errors, while it was simplyresultWhat does this change do?
Fixes above
What is your testing strategy?
Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.
Is this related to any issues?
If this pull request is related to any other pull request or issue, or resolves any issues - then link all related pull requests and issues here.
Have you read the Contributing Guidelines?