Fix live query UUID #236
Merged
Fix live query UUID #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The driver currently expects a UUID format string for the live query ID. However, it is actually decoded as a UUID class, not a string. Therefore, the live and subscribeLive methods always fail.
There are no tests for live queries. We need to make sure that live and subscribeLive, unSubscribeLive, kill methods work.
kearfy
approved these changes
Apr 20, 2024
|
Great find @tai-kun, and thank you for adding some tests around live queries! Hadn't found the time to add them myself but this is great 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the great work on this project.
What is the motivation?
I was unable to subscribe to record changes using the live method. After researching, I found the following:
z.string().uuid().What does this change do?
What is your testing strategy?
Add three tests to
tests/integration/tests/live.ts:livemethod returns a UUID class on the WebSocket engine and verifies that live queries work. Also, checks that it fails on the HTTP engine.livemethod. As far as the HTTP engine is concerned, it doesn't support this, so we don't test anything.livemethod. As far as the HTTP engine is concerned, it doesn't support this, so we don't test anything.Is this related to any issues?
N/A
Have you read the Contributing Guidelines?