Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.
What is the motivation?
We improved
toJSON
support in #256 with the slight oversight that native datatypes don't generally have a toJSON method.What does this change do?
It introduces a
jsonify
method which effectively JSON stringifies the passed value and then parses it again, allthough it adds typing to it to preserve the type of the passed value and converts them.We're going with a simple stringify + parse method because we need a bit more time if something custom which would loop through all values recursively could be faster and acurate.
What is your testing strategy?
Transformed the
toJSON
unit test intojsonify
Is this related to any issues?
Continuation of #256
Have you read the Contributing Guidelines?