fix: web build #46
Merged
fix: web build #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we add a test running the web build in a browser environment? |
|
I don't think that it is worth adding this. We might rerun the deno tests on this build (should work)... |
oberbeck
added a commit
to oberbeck/surrealdb.rxjs
that referenced
this pull request
Sep 24, 2022
note: pending web build surrealdb/surrealdb.js#46
oberbeck
added a commit
to oberbeck/surrealdb.rxjs
that referenced
this pull request
Sep 24, 2022
note: pending web build surrealdb/surrealdb.js#46
|
Is this ready to merge @mathe42? |
|
Yes ready to merge |
|
@tobiemh ready to merge! |
|
@mathe42 I'm not so sure about moving from iife to esm, what is your motivation behind this? |
kearfy
reviewed
May 5, 2023
kearfy
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.