Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 improve dotnet release versions section #20

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

Odonno
Copy link
Contributor

@Odonno Odonno commented Sep 25, 2023

  • Change rules about .NET release version (LTS, STS, .NET Standard 2.1)
  • Display the list of currently supported .NET versions, with their official End of Support
  • Add .NET 7 as a target framework for the library

Note that I did not see any changes needed to be done for .NET 7, nor did I see any noticeable performance improvement.

@Odonno Odonno marked this pull request as ready for review September 25, 2023 15:06
@s-e-f
Copy link

s-e-f commented Sep 27, 2023

Note that benchmarks and tests need to be updated to target this additional runtime version too.

@s-e-f
Copy link

s-e-f commented Sep 27, 2023

Using Directory.Build.props can help in centralizing and syncing the different runtime versions across projects.

@s-e-f
Copy link

s-e-f commented Sep 27, 2023

For the readme, perhaps we can simplify the support structure to something along the lines of:

SurrealDb.Net targets .NET versions that are in support by Microsoft.

Additionally, SurrealDb.Net targets .NET Standard 2.1 explicitly for the Unity ecosystem.

A link to the Microsoft .NET support window might be helpful too to clarify the difference between STS/LTS, exact dates from the source. This also covers the overlap that exists for a short period between .NET releases, which is technically not covered by the current explanation.

@Odonno
Copy link
Contributor Author

Odonno commented Sep 27, 2023

Note that benchmarks and tests need to be updated to target this additional runtime version too.

I tested these projects locally with .NET 7, but yes, I commit & push the upgrade.

@Odonno
Copy link
Contributor Author

Odonno commented Sep 27, 2023

Using Directory.Build.props can help in centralizing and syncing the different runtime versions across projects.

Using this file is planned to centralize used packages, versioning, etc... I think there is not enough projects in the solution to implement it at the moment but it can be a nice addition later.

@kearfy kearfy merged commit b475c08 into surrealdb:main Oct 16, 2023
1 of 2 checks passed
@Odonno Odonno deleted the docs/dotnet-versions branch October 16, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants