-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor quality of life suggestions #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice. Some minor changes requested.
SurrealDb.Net/Extensions/DependencyInjection/ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
Regards the RawValue and Deserialising... it might make sense for us to just expose the JsonElement with a private setter? |
I've made the changes requested. Also I have added a check in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @simon-curtis, formatting seems to fail. Could you check that out? Thanks! |
Indeed, this project is using https://csharpier.com/ You can run it locally in the cli by installing the dotnet tool on your machine. Or automatically in your favorite IDE as an extension. There is one for Rider. I will update the readme for newcomers. |
I've formatted but it hasn't made any changes? |
You have an additional whitespace at the end of line: public JsonElement Value { get; } Can you check it isn't there anymore? |
All done! Codespaces had checkout the wrong branch for some reason. Yes the space after the the property is gone now |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
- Coverage 70.58% 70.37% -0.21%
==========================================
Files 109 109
Lines 3617 3629 +12
Branches 368 369 +1
==========================================
+ Hits 2553 2554 +1
- Misses 883 893 +10
- Partials 181 182 +1 ☔ View full report in Codecov by Sentry. |
I have:
.AddSurrealDb(o => o.WithDatabase(...))
, it's the type I personally reach for the most when configuring services.