Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolated string query #66

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

Odonno
Copy link
Contributor

@Odonno Odonno commented Dec 27, 2023

Closes #13

@Odonno Odonno marked this pull request as draft December 28, 2023 09:34
@Odonno Odonno force-pushed the feat/interpolated-string-query branch from 109ae6a to 0778138 Compare December 28, 2023 12:05
@Odonno Odonno force-pushed the feat/interpolated-string-query branch from b299928 to 2987fc3 Compare January 20, 2024 13:47
@Odonno Odonno marked this pull request as ready for review January 20, 2024 13:47
@codecov-commenter
Copy link

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (513ccbc) 69.47% compared to head (a961d86) 69.41%.

Files Patch % Lines
...b.Reactive/Extensions/SurrealDbClientExtensions.cs 73.33% 16 Missing ⚠️
SurrealDb.Net/Internals/SurrealDbEngine.Ws.cs 56.25% 5 Missing and 2 partials ⚠️
SurrealDb.Net/SurrealDbClient.cs 80.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
- Coverage   69.47%   69.41%   -0.07%     
==========================================
  Files         110      111       +1     
  Lines        4324     4433     +109     
  Branches      425      430       +5     
==========================================
+ Hits         3004     3077      +73     
- Misses       1105     1141      +36     
  Partials      215      215              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kearfy kearfy merged commit f5903a4 into surrealdb:main Jan 29, 2024
2 checks passed
@Odonno Odonno deleted the feat/interpolated-string-query branch January 29, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Interpolated Parameterization
3 participants