Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ make Live Query tests pass #71

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

Odonno
Copy link
Contributor

@Odonno Odonno commented Jan 16, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (90a3e09) 70.72% compared to head (da577d8) 70.69%.

Files Patch % Lines
...rrealDb.Net/Models/LiveQuery/SurrealDbLiveQuery.cs 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   70.72%   70.69%   -0.03%     
==========================================
  Files         110      110              
  Lines        3795     3795              
  Branches      377      377              
==========================================
- Hits         2684     2683       -1     
  Misses        924      924              
- Partials      187      188       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Odonno Odonno force-pushed the fix/live-query-tests-nightly branch from d5f9467 to c6ebfcd Compare January 16, 2024 18:48
@Odonno Odonno force-pushed the fix/live-query-tests-nightly branch from c6ebfcd to da577d8 Compare January 16, 2024 18:52
@Odonno Odonno changed the title ✅ make Live Query tests pass against nightly version ✅ make Live Query tests pass again Jan 16, 2024
@Odonno Odonno changed the title ✅ make Live Query tests pass again ✅ make Live Query tests pass Jan 16, 2024
@kearfy kearfy merged commit 5293945 into surrealdb:main Jan 17, 2024
1 check passed
@Odonno Odonno deleted the fix/live-query-tests-nightly branch January 17, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants