Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unicode error #57

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Fix unicode error #57

merged 1 commit into from
Apr 20, 2023

Conversation

AlexFrid
Copy link
Contributor

What is the motivation?

Fixing a parse error with using unicode characters in strings.

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

What does this change do?

Makes sure the json.dumps doesn't automatically convert unicode characters.

What is your testing strategy?

Ran manual suite on all the affected methods.

Is this related to any issues?

Yes: #56

Have you read the Contributing Guidelines?

@AlexFrid AlexFrid merged commit db003c6 into main Apr 20, 2023
@AlexFrid AlexFrid deleted the bugfix-unicode branch April 20, 2023 15:15
maxwellflitton pushed a commit that referenced this pull request Jun 19, 2023
Co-authored-by: Alexander <post@alexanderfridiksson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant