Add websocket implementation #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
September 17, 2022 22:41
|
unfortunately the commit history is quite messy for this, it requires #5 for merging but includes the history from that PR too. if anyone would like to help out with typing the request & responses for this that would be great, since there is no documentation for them nor any typing on the other language's libraries; i would not have to keep response & return types as |
|
PR good to go! some typing may need to be improved further down the line when we have better docs, but based on everything explained on discord it can't really get any better currently. authentication, creating records & reading records has been tested; if anyone wants to test the rest before-hand then feel free! |
Closed
CaedenPH
reviewed
Sep 18, 2022
There was a problem hiding this comment.
I don't like the class names SurrealDBHTTPClient or SurrealDBWSClient. It's like 4 words joined into one, whereas the clients could be separated into different directories and used like;
from surrealdb.ws import WebsocketClient
from surrealdb.http import HttpClient
Co-authored-by: Caeden <caedenperelliharris@gmail.com>
Co-authored-by: Caeden <caedenperelliharris@gmail.com>
CaedenPH
reviewed
Sep 18, 2022
|
added #7 to http client, resolved merge conflicts. good for merge! |
maxwellflitton
pushed a commit
that referenced
this pull request
Jun 19, 2023
* feat: add pre-commit config * feat: add dev requirements * feat: implement sync & async clients * chore: run formatter * chore: rename sync client for consistency * chore: add `__all__` to all files * chore: refine imports * feat: improve compatibility for lower py versions * chore: run formatter * feat: change `__all__` to use tuples instead of lists * feat: add extra dunder module attributes * chore: remove author from setup.py * chore: remove author dunder attribute and add copyright * chore: add copyright headers to files * feat: switch to black * feat: add license to setup.py * chore: run formatter * feat: add more pre-commit hooks * chore: run formatter * fix: replace autopep8 with black in dev requirements * feat: add pyproject.toml file for poetry * chore: change versioning * chore: remove unused `requests` dependency * fix: change `method` type annotation to `str` to support 3.7 * fix: more changes to complete py3.7 support * feat: add author * fix: `orjson` in requirements.txt * feat: move exceptions from folder into single file * fix: incorrect exception import * feat: rename `SurrealDBClient` to `SyncSurrealDBClient` * feat: remove sync client, move & rename async client * chore: remove un-used requirements file * force `namespace`, `database`, `username` and `password` to be keyword arguments * chore: delete setup.py inplace of pyproject.toml * fix: add `Optional`s on `__aexit__` * chore: add .vscode to gitignore * chore: move client.py to clients/http.py * chore: remove unused dev requirements * feat: add ws requirements * feat: add base ws client, increment library version * feat: add TypedDict for ws request * feat: add response listening, add remaining request types * feat: force args after `url` to be keyword * feat: add username/password auth from ctor * fix: bugs on authentication * feat: add ping * feat: improve function typing * feat: further improve typing * fix: remove old client * Update surrealdb/clients/ws.py Co-authored-by: Caeden <caedenperelliharris@gmail.com> * Update surrealdb/clients/ws.py Co-authored-by: Caeden <caedenperelliharris@gmail.com> * fix: list type annotation * feat: remove unused import and add future annotations * chore: rename `SurrealDBWSClient` to `SurrealDBWebsocketClient` * chore: remove `SurrealDB` suffix from client names * fix: port #7 to http client Co-authored-by: tsunyoku <mbruhyo@gmail.com> Co-authored-by: Caeden <caedenperelliharris@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a wrapper around the WebSocket API of SurrealDB as it is more feature-ful than the REST API, providing people with the ability to use either.