Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'merge' in ws.py #85

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix 'merge' in ws.py #85

wants to merge 1 commit into from

Conversation

chrda81
Copy link

@chrda81 chrda81 commented Dec 26, 2023

Response message "Method not found" is received with error_code "SurrealPermissionException", so I guess the method="change" is obsolete.

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What is the motivation?

Type of Change

  • 馃摎 Examples / docs / tutorials / dependencies update
  • 馃敡 Bug fix (non-breaking change which fixes an issue)
  • 馃 Improvement (non-breaking change which improves an existing feature)
  • 馃殌 New feature (non-breaking change which adds functionality)
  • 馃挜 Breaking change (fix or feature that would cause existing functionality to change)
  • 馃攼 Security fix

What does this change do?

This change fixes the 'merge' function.

What is your testing strategy?

Is this related to any issues?

Have you read the Contributing Guidelines?

Response message "Method not found" is received with error_code "SurrealPermissionException", so I guess the method="change" is obsolete.
@Wouterkoorn
Copy link

Wouterkoorn commented Apr 1, 2024

I encountered the same problem when using Surreal.patch. Would you mind checking all methods, and extending this fix for them all?
I guess same PR is fine 馃し

@Wouterkoorn
Copy link

I encountered the same problem when using Surreal.patch. Would you mind checking all methods, and extending this fix for them all?~ ~I guess same PR is fine 馃し

I see now that the whole patch method is wrong, and more changes are needed than just changing the method name. I will create separate issue/PR - apologies for the spam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants