Make FoundationDB version configurable #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the motivation?
The FoundationDB version of the library that SurrealDB links to needs to match the version of the FoundationDB server.
What does this change do?
It makes the FDB library version that we link to configurable so we don't lock in our users to a particular version
What is your testing strategy?
Made sure tests still pass and tested that linking to different versions works (in a separate PR).
Is this related to any issues?
It was extracted from #100. Though it's needed by that PR, it's useful outside it.
Have you read the Contributing Guidelines?