error on undefined field #3250
Closed
error on undefined field #3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will be a breaking change, should we assign it to the v2.0.0 milestone perhaps? |
RaphaelDarley
added
the
topic:schema
|
that seems reasonable, though it might be better to incorporate this with larger schema changes |
|
Could we also have some test coverage please? This can be in the doc tests or in the api or both |
tobiemh
added
the
needs-documentation
|
closed in favour of #3872 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.
What is the motivation?
When adding data into a schemaful table any undefined fields are currently dropped silently, I don't think data should ever be dropped silently.
What does this change do?
Error when a query attempts to write to undefined fields, which will be dropped.
What is your testing strategy?
Tests have not been written yet.
Does this change need documentation?
Have you read the Contributing Guidelines?