Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graphql support #3266

Draft
wants to merge 49 commits into
base: main
Choose a base branch
from

Conversation

RaphaelDarley
Copy link
Contributor

@RaphaelDarley RaphaelDarley commented Jan 4, 2024

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What is the motivation?

GraphQL is a useful tool with a large ecosystem surrounding it, allowing SurrealDB to integrate with that will ease adoption and increase use cases.

What does this change do?

This pr adds a new /gql endpoint, which allows proves an autogenerated schema, as well as allowing custom functions to be exposed, then parses, validates and executes graphql queries.

What is your testing strategy?

Testing not currently implemented.

Is this related to any issues?

Closes #2379.

Does this change need documentation?

  • Yes documentation is needed

Have you read the Contributing Guidelines?

@RaphaelDarley RaphaelDarley added the topic:graphql This is related to GraphQL querying and schame label Jan 4, 2024
@itsezc
Copy link

itsezc commented Jan 12, 2024

Great to see some movement on this, might be minor; /graphql is the usual endpoint, thanks!

Comment on lines +18 to +19
pub from: Option<Kind>,
pub to: Option<Kind>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we internally keep calling these in and out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue with that is in is a keyword so you'd have to do #in

@itsezc itsezc mentioned this pull request Feb 9, 2024
2 tasks
@tobiemh tobiemh added the needs-documentation Needs documentation to be added and tracked before merge label Feb 28, 2024
@RaphaelDarley RaphaelDarley mentioned this pull request Apr 2, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-documentation Needs documentation to be added and tracked before merge topic:graphql This is related to GraphQL querying and schame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: GraphQL Server
4 participants