Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to 1.77 #3778

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Bump MSRV to 1.77 #3778

merged 1 commit into from
Mar 27, 2024

Conversation

rushmorem
Copy link
Collaborator

@rushmorem rushmorem commented Mar 27, 2024

What is the motivation?

Since #3591 was merged, we now have a requirement for Rust v1.77. Our build tooling still depends on v1.75. This broke the nightly builds.

What does this change do?

It updates the Rust dependency to v1.77.

What is your testing strategy?

Github Actions.

Is this related to any issues?

No.

Does this change need documentation?

If this pull request requires changes, updates, or improvements to the documentation, then add a corresponding issue on the docs.surrealdb.com repository, and link to it here.

  • No documentation needed

Have you read the Contributing Guidelines?

@rushmorem rushmorem marked this pull request as ready for review March 27, 2024 18:08
@rushmorem rushmorem requested review from a team and tobiemh as code owners March 27, 2024 18:08
@tobiemh tobiemh added this pull request to the merge queue Mar 27, 2024
Merged via the queue into surrealdb:main with commit 464837c Mar 27, 2024
22 checks passed
@rushmorem rushmorem deleted the fix-nightly branch March 27, 2024 19:13
@rushmorem rushmorem mentioned this pull request Mar 27, 2024
2 tasks
jonathanmetzman pushed a commit to google/oss-fuzz that referenced this pull request Apr 5, 2024
The rust-lang/rust#110475 issue referenced is no longer a problem since
the `geo` crate has been updated in SurrealDB. However, the change in
default Rust version in the image builder implemented in
#11681 breaks fuzzing due to SurrealDB now requiring Rust
1.77 after surrealdb/surrealdb#3591, leading to
a bump in the MSRV in surrealdb/surrealdb#3778.

I have replaced the obsolete `--cfg uuid_unstable` for the generic
`--cfg surrealdb_unstable`, which will allow fuzzing any features still
deemed unstable in SurrealDB including the new experimental parser.
@rushmorem rushmorem added this to the v1.5.0-beta.1 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants