Fix fuzzing #3800
Merged
Fix fuzzing #3800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request! We really appreciate you spending the time to work on these changes.
What is the motivation?
Fuzzing was broken after some changes in optional features that were reverted in #3793. Fuzzing was also broken due to some types missing the
arbitrarytrait. The motivation for this PR is to fix fuzzing and ensure that it does not accidentally break again.What does this change do?
This PR adds the missing
arbitrarytraits and incorporates a new job in CI to check that fuzzers can be build independently and in the OSS-Fuzz environment. This action will still fail until OSS-Fuzz uses the required 1.77 version of Rust. The change in google/oss-fuzz#11777 now explicitly referencesnightlyto be used for SurrealDB. The CI job that checks the build of OSS-Fuzz has been allowed to fail, as this PR needs to be merged before the previously mentioned PR can be merged on OSS-Fuzz, as it requires the changes in this PR to pass its own build.What is your testing strategy?
Use the new action to verify that fuzzers build correctly.
Is this related to any issues?
No. This is related to the fuzzing build errors returned by OSS-Fuzz.
Does this change need documentation?
Have you read the Contributing Guidelines?